Re: [PATCH] ath9k: Revert change that broke AR928X on Acer FerrariOne

[Felix Fietkau]

On 2011-11-27 8:16 AM, Adrian Chadd wrote:
> Hm, considering the origina patch did this:
> 
>         /* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */
> -       if (AR_SREV_9300_20_OR_LATER(ah))
> -               REG_WRITE(ah, AR_WA,
> -                         ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
> +       if (!AR_SREV_9480(ah))
> +               REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
> 
> .. something tells me that perhaps the correct statement is:
> 
> if (AR_SREV_9300_20_OR_LATER(ah) && !AR_SREV_9480(ah))
>     REG_WRITE() ...
> 
I checked again, the !AR_SREV_9480(ah) was intentionally removed in a
later change, so using AR_SREV_9300_20_OR_LATER(ah) is correct.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/