Re: [PATCH 6/8] ASoC: SigmaDSP: Provide diagnostic error messages

[Lars-Peter Clausen]

On 11/24/2011 06:32 PM, Mike Frysinger wrote:
> On Thursday 24 November 2011 07:48:25 Lars-Peter Clausen wrote:
>> +	if (crc != le32_to_cpu(ssfw_head->crc)) {
>> +		dev_err(&client->dev, "Failed to load firmware: Wrong crc checksum:" \
>> +			" expected %x got %x.\n",
> 
> it's my understanding that string constants should not be split
> -mike

I think it is fine here. You probably wouldn't grep for %x anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/