Re: [PATCH v2 14/14] Change CPUACCT to default n

From: Glauber Costa
Date: Thu Nov 24 2011 - 11:08:15 EST


On 11/24/2011 11:24 AM, Peter Zijlstra wrote:
On Mon, 2011-11-21 at 10:59 +0900, KAMEZAWA Hiroyuki wrote:
Could you share your analysis why cpuacct cgroup is slow ?

It adds accounting to all scheduler hot paths, accounting that is mostly
duplicate of accounting already done. It also does another cgroup
hierarchy walk, separate from existing controllers, hitting all cold
cachelines again.

IOW, it sucks chunks and I should never have allowed it to be merged.

OTOH, if the use case for it includes separating processes for the cpu and cpuacct cgroups in an independent manner - which apparently it does, I've just learned, there isn't much we can do except try to make it cheaper.

The direction I am going right now wrt this is to clean this up and reduce the impact of it when the root cgroup is the only one active. All other users are using the functionality, so let them pay...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/