[patch] uprobes: add_utask() returns an ERR_PTR() not NULL

From: Dan Carpenter
Date: Thu Nov 24 2011 - 02:18:49 EST


We need to check for IS_ERR() here (add_utask() never returns NULL).

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/kernel/uprobes.c b/kernel/uprobes.c
index 2493191..3360057 100644
--- a/kernel/uprobes.c
+++ b/kernel/uprobes.c
@@ -1387,8 +1387,10 @@ void uprobe_notify_resume(struct pt_regs *regs)
if (!utask) {
utask = add_utask();
/* Cannot Allocate; re-execute the instruction. */
- if (!utask)
+ if (IS_ERR(utask)) {
+ utask = NULL;
goto cleanup_ret;
+ }
}
utask->active_uprobe = u;
handler_chain(u, regs);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/