Re: [Intel-gfx] [PATCH] iommu: export no_iommu and dmar_disabledsymbols

From: David Woodhouse
Date: Wed Nov 23 2011 - 15:36:08 EST


On Wed, 2011-11-23 at 16:42 -0200, Eugeni Dodonov wrote:
> Those are needed by the rc6 and semaphores support in i915 driver.
>
> In i915 driver, we do not enable either rc6 or semaphores on SNB when dmar
> is enabled. So we use those variables to check the io remapping and iommu
> status.

This is horrid. In the general case, drivers have no business knowing
this. We need to properly identify what is wrong with this hardware, and
put in a quirk for it â perhaps refusing to enable the IOMMU at all on
the broken chipsets.

--
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature