RE: [PATCH 1/1] gpio: gpio-mxs: remove the duplicated micro define

[Dong Aisheng-B29396]

 -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Stephen Warren
> Sent: Wednesday, November 16, 2011 2:42 AM
> To: Dong Aisheng; linux-kernel@xxxxxxxxxxxxxxx
> Cc: grant.likely@xxxxxxxxxxxx; arnd@xxxxxxxx; s.hauer@xxxxxxxxxxxxxx; Guo
> Shawn-R65073; kernel@xxxxxxxxxxxxxx
> Subject: RE: [PATCH 1/1] gpio: gpio-mxs: remove the duplicated micro
> define
> 
> Dong Aisheng wrote at Tuesday, November 15, 2011 2:55 AM:
> ...
> > diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> ...
> > -#define MXS_SET		0x4
> > -#define MXS_CLR		0x8
> 
> If the long-term direction on MXS is to move to gpiolib, won't
It looks gpio-mxs driver is already using gpiolib.

> MX_SET_ADDR etc. and the inline functions that use it eventually be
> removed from mach-mxs/include/mach/mxs.h hence requiring the #define be
> moved back into the GPIO driver?
> 
Yes, i agree with you.
Eventually we will remove using <mach/mxs.h>.
Thanks for the comments.

Regards
Dong Aisheng


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/