Re: [PATCH 1/3] tty: make several fops functions non-static so thatthe pty code can use them

From: Greg KH
Date: Tue Nov 15 2011 - 15:22:24 EST


On Sun, Oct 30, 2011 at 09:40:38AM -0700, Arjan van de Ven wrote:
> From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
>
> The pty code currently does a partial function-pointer copy to fill its
> struct file_operations; this patch makes the functions it copies non-static
> in preparation of switching the pty code over to using proper prototypes.
>
> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>

With this patch, I get the following build error:

drivers/tty/tty_io.c:2712:13: error: static declaration of âtty_compat_ioctlâ follows non-static declaration
include/linux/tty.h:492:13: note: previous declaration of âtty_compat_ioctlâ was here
drivers/tty/tty_io.c:2712:13: warning: âtty_compat_ioctlâ defined but not used

Please fix up the series and resend them, in a format that I can apply
them in, without having to edit the body of the patch by hand.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/