Re: [PATCH 0/2] irq/of: Enchance irq_domain support.

[David Daney]

On 11/11/2011 07:55 PM, Rob Herring wrote:
> On 11/11/2011 07:50 PM, ddaney.cavm@xxxxxxxxx wrote:
> > From: David Daney<david.daney@xxxxxxxxxx>
> >
> > This is the first cut at hooking up my Octeon port to the irq_domain things.
> >
> > The Octeon specific patches are part of a larger set, and will need to
> > be applied with that set, the first patch is stand-alone.
> >
> > The basic problem being solved taken from one of my other e-mails:
> >
> >     Unfortunately, although a good idea, kernel/irq/irqdomain.c makes a
> >     bunch of assumptions that don't hold for Octeon.  We may be able to
> >     improve it so that it flexible enough to suit us.
> >
> >
> >     Here are the problems I see:
> >
> >     1) It is assumed that there is some sort of linear correspondence
> >     between 'hwirq' and 'irq', and that the range of valid values is
> >     contiguous.
> >
> >     2) It is assumed that the concepts of nr_irq, irq_base and
> >     hwirq_base have easy to determine values and you can do iteration
> >     over their ranges by adding indexes to the bases.
>
> I still think this is the wrong approach.
>
> Are the gpio interrupts the source of your problem here?

No.

> That's how I read it.

Take a look at Patch 2/2, since the GPIO irqs are contiguous over both 
irq and hwirq numbers, I use the existing infrastructure with no 
modifications.

> You have 16 GPIO irqs directly connected into lines on your
> primary interrupt controller which has 128 lines. So for a Linux irq
> number, you want to translate to a GPIO hwirq number and/or a CIU hwirq
> number. Trying to have 2 hwirq mappings for 1 Linux irq number just
> won't work. It seems to me you should use a chained handler here because
> you need to process the interrupt at both the primary ctrlr and gpio
> ctrlr levels.

All moot as it is based on the false predicate of GPIO irqs being the 
problem.


The root of the problem are all of the irqs that are not GPIO.  I have:

o irq numbers currently in the range [9..196], with holes for any given 
SOC/Board implementation.  SOCs currently in development will have 
additional irq numbers with even more holes.

o Two different interrupt controllers.  One with 128 lines, the other 
with  512 or more lines, both sparsely populated.  The mapping of hwirq 
to irq is done at boot time based on the hardware the kernel image is 
running on.  Note that the second type of irq controller support is not 
in the kernel.org kernel, but it exists, and I intend on getting support 
for it merged ASAP.

At a minimum the loop in irq_domain_add() where we iterate over a linear 
range of irq numbers is not flexible enough.  You may not like my 
iterator functions in irq_domain_ops, but we need to provide something 
better than the irq_domain_for_each_irq() macro.

David Daney


> Rob
>
> > David Daney (2):
> >    irq/of/ARM: Enhance irq iteration capability of irq_domain code.
> >    MIPS: Octeon: Add irq_create_of_mapping() and GPIO interrupts.
> >
> >   arch/arm/common/gic.c                |   32 +++--
> >   arch/mips/Kconfig                    |    1 +
> >   arch/mips/cavium-octeon/octeon-irq.c |  279 +++++++++++++++++++++++++++++++++-
> >   include/linux/irqdomain.h            |   29 +++-
> >   kernel/irq/irqdomain.c               |   97 +++++++++---
> >   5 files changed, 390 insertions(+), 48 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/