Re: [PATCH] TTY: tty flip buffer with synchronous line disciplines.

From: Alan Cox
Date: Mon Nov 14 2011 - 12:48:13 EST


On Mon, 14 Nov 2011 21:41:36 +0400
Ilya Zykov <ilya@xxxxxxx> wrote:

> For use flip buffer with synchronous line disciplines(n_hdlc, ppp_synctty).

If you are doing synchronous protocols then they shouldn't be going via
the tty loopback in the first place. Why can't you use tuntap and the
like for synchronous protocols ? Stuffing them through the tty layer is a
bad hack anyway and not one we should encourage further.

> + if ((b = tty->buf.tail) != NULL && !tty->pty_sync)
> left = b->size - b->used;

What stops tty->pty_sync changing under the line discipline btw ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/