Re: [PATCH v2 04/16] mtd/docg3: fix BCH registers

From: Robert Jarzmik
Date: Sun Nov 13 2011 - 05:20:23 EST


Mike Dunn <mikedunn@xxxxxxxxxxx> writes:

> On 11/10/2011 12:05 AM, Robert Jarzmik wrote:
>> -#define DOC_BCH_SYNDROM(idx) (0x1048 + (idx << 1))
>> +#define DOC_BCH_SYNDROM(idx) (0x1048 + (idx << 0))
>
>
> Minor nit: why the 0, and not just (0x1048 + idx) ?
I'll fix that, old idea I had that address bus did not stand odd adresses, and I
couldn't convince myself the "<< 0" was right, so left it to have back quicky
"<< 1". But I was wrong :)

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/