Re: [PATCH net-next v1] net-forcedeth: Add internal loopbacksupport for forcedeth NICs.

[David Miller]

From: Sanjay Hortikar <horti@xxxxxxxxxx>
Date: Wed,  9 Nov 2011 12:45:25 -0800

> @@ -5124,6 +5266,12 @@ static int nv_open(struct net_device *dev)
>  
>  	spin_unlock_irq(&np->lock);
>  
> +	/* If the loopback feature was set while the device was down, make sure
> +	* that it's set correctly now.
> +	*/

Improperly formatted comment, it should be:

	/*
	 *
	 */

> @@ -5328,6 +5476,10 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
>  
>  	dev->features |= dev->hw_features;
>  
> +	/* Add loopback capability to the device. */
> +	dev->hw_features |= NETIF_F_LOOPBACK;
> +
> +
>  	np->pause_flags = NV_PAUSEFRAME_RX_CAPABLE | NV_PAUSEFRAME_RX_REQ | NV_PAUSEFRAME_AUTONEG;

Please do not add all of these extra empty lines.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/