Re: [PATCH v3 1/4] mm: add free_hot_cold_page_list helper
From: Minchan Kim
Date: Fri Nov 11 2011 - 18:32:59 EST
On Fri, Nov 11, 2011 at 10:39 PM, Konstantin Khlebnikov
<khlebnikov@xxxxxxxxxx> wrote:
> This patch adds helper free_hot_cold_page_list() to free list of 0-order pages.
> It frees pages directly from the list without temporary page-vector.
> It also calls trace_mm_pagevec_free() to simulate pagevec_free() behaviour.
>
> bloat-o-meter:
>
> add/remove: 1/1 grow/shrink: 1/3 up/down: 267/-295 (-28)
> function                   old   new  delta
> free_hot_cold_page_list            Â-   264  Â+264
> get_page_from_freelist           Â2129  Â2132   Â+3
> __pagevec_free                243   239   Â-4
> split_free_page               Â380   373   Â-7
> release_pages                Â606   510   -96
> free_page_list                188    -  Â-188
>
> v2: Remove list reinititialization.
> v3: Always free pages in reverse order.
> Â ÂThe most recently added struct page, the most likely to be hot.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
--
Kind regards,
Minchan Kim
¢éì®&Þ~º&¶¬+-±éÝ¥w®Ë±Êâmébìdz¹Þ)í
æèw*jg¬±¨¶Ýj/êäz¹Þà2Þ¨èÚ&¢)ß«a¶Úþø®G«éh®æj:+v¨wèÙ>W±êÞiÛaxPjØm¶ÿÃ-»+ùd_