Re: [PATCH] ata: Fix build error in pata_of_platform (NO_IRQ usage)
From: Alan Cox
Date: Thu Nov 10 2011 - 10:35:25 EST
> The proper fix (stop OF code from returning NO_IRQ values) is pending.
Please just apply the proper fix.
> - The NO_IRQ disease spreads despite our willingness, even within
> the new OF code.
Then it can stop right here, because if the arch people don't fix their
code to use zero their ATA port won't work.
> +/* For archs that don't support NO_IRQ (such as x86), provide a dummy value */
> +#ifndef NO_IRQ
> +#define NO_IRQ 0
> +#endif
NAK - just test against zero. They've been complained at about this for
over two years. Enough is enough.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/