Re: [patch 2/5]thp: remove unnecessary tlb flush for mprotect

[Andrea Arcangeli]

On Tue, Oct 25, 2011 at 10:59:25AM +0800, Shaohua Li wrote:
> change_protection() will do TLB flush later, don't need duplicate tlb flush.
> 
> Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
> ---
>  mm/huge_memory.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux/mm/huge_memory.c
> ===================================================================
> --- linux.orig/mm/huge_memory.c	2011-10-24 19:24:31.000000000 +0800
> +++ linux/mm/huge_memory.c	2011-10-24 19:25:10.000000000 +0800
> @@ -1079,7 +1079,6 @@ int change_huge_pmd(struct vm_area_struc
>  			entry = pmd_modify(entry, newprot);
>  			set_pmd_at(mm, addr, pmd, entry);
>  			spin_unlock(&vma->vm_mm->page_table_lock);
> -			flush_tlb_range(vma, addr, addr + HPAGE_PMD_SIZE);
>  			ret = 1;
>  		}
>  	} else

Reviewed-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/