Re: [RFC/GIT PULL] Linux KVM tool for v3.2

From: Pekka Enberg
Date: Thu Nov 10 2011 - 08:56:19 EST


Hi Anthony,

On Thu, Nov 10, 2011 at 3:43 PM, Anthony Liguori <anthony@xxxxxxxxxxxxx> wrote:
> It's not just the qcow2 implementation or even the block layer.  This pull
> requests adds a userspace TCP/IP stack to the kernel and yet netdev isn't on
> the CC and there are no Ack's from anyone from the networking stack.  I'm
> fairly sure if they knew what was happening here they would object.

It's something we consider extremely important because it allows easy
non-root networking. But you're right, we definitely ought to ping the
networking folks before the next merge window.

On Thu, Nov 10, 2011 at 3:43 PM, Anthony Liguori <anthony@xxxxxxxxxxxxx> wrote:
>> Would you be interested in spending another 30 seconds to find out some
>> more issue? :-)
>
> I could, provided you could take the things you want to do differently and
> submit them as patches to qemu.git instead of creating a new tool.
>
> There are lots of people on qemu-devel than can provide deep review of this
> type of code.  That's the advantage of working in qemu.git.

I fully understand if you don't want to spend your time reviewing the
KVM tool code. I'm just saying that if you do spend the next 30
seconds next time you're bored, I'm all ears and happy to fix any
issues you point out.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/