Re: [V2][PATCH 5/5] oprofile, x86: Reimplement nmi timer mode usingperf event

From: Peter Zijlstra
Date: Thu Nov 10 2011 - 07:52:21 EST


On Sun, 2011-10-23 at 13:27 +0200, Ingo Molnar wrote:
> * Robert Richter <robert.richter@xxxxxxx> wrote:
>
> > The legacy x86 nmi watchdog code was removed with the implementation
> > of the perf based nmi watchdog. This broke Oprofile's nmi timer
> > mode. To run nmi timer mode we relied on a continuous ticking nmi
> > source which the nmi watchdog provided. The nmi tick was no longer
> > available and current watchdog can not be used anymore since it runs
> > with very long periods in the range of seconds. This patch
> > reimplements the nmi timer mode using a perf counter nmi source.
> >

> Looks clean to me. Peter, any objections?

No.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/