Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture

From: ANNIE LI
Date: Wed Nov 09 2011 - 20:57:11 EST




On 2011-11-10 0:22, Ian Campbell wrote:
IMHO the gnttab_ bit belongs in either (or both) the struct name or the
variable names referencing the struct, rather than the fields
themselves. It should be obvious from the context that this member is
something to do with gnttab. e.g. I think gnttab_shared->addr would be
fine, as would shared->addr in the context of gnttab.c etc.
Right.
Thanks you all for the review, I will improve patches based on those suggestions and resend them.

Thanks
Annie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/