Re: [PATCH 0/2] AH fixes for asynchronous hash algorithms.

From: David Miller
Date: Wed Nov 09 2011 - 15:56:34 EST


From: Nick Bowler <nbowler@xxxxxxxxxxxxxxxx>
Date: Tue, 8 Nov 2011 17:12:43 -0500

> Here are two fixes for AH when using an asynchronous hmac driver. Both
> are -stable candidates as these problems appear to have been present
> since AH was converted to use ahash way back in 2.6.33.
>
> These code paths are not exercised when using the default software hash
> implementations which do not use the ahash callbacks, but the issues can be
> reproduced by using cryptd to create an asynchronous hash algorithm for
> testing.
>
> This driver could probably do with some cleanups to reduce the code
> duplication (and thus test coverage) between the asynchronous callbacks
> and synchronous code paths, which should help avoid these kind of
> problems in the future. These code paths apparently do not see a
> lot of testing. But that's for a later patch series.
>
> Nick Bowler (2):
> ah: Correctly pass error codes in ahash output callback.
> ah: Read nexthdr value before overwriting it in ahash input callback.

Thanks a lot for these bug fixes Nick, both applied.

Also queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/