Re: [PATCH] net: drivers/net/hippi/Kconfig should be sourced

[David Miller]

From: Paul Bolle <pebolle@xxxxxxxxxx>
Date: Tue, 08 Nov 2011 21:31:10 +0100

> Commit ff5a3b509e ("hippi: Move the HIPPI driver") moved the HIPPI
> driver into drivers/net/hippi. It didn't source
> drivers/net/hippi/Kconfig though, so it didn't make all necessary
> Kconfig changes. So let drivers/net/kconfig source HIPPI's Kconfig file.
> 
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> git grep tested only. Perhaps the exact spot where
> drivers/net/hippi/Kconfig gets sourced is relevant, so this needs
> (build) testing by people actually familiar with the HIPPI driver. 

Please at least type "make oldconfig" with CONFIG_HIPPI enabled or
similar before submitting patches like this.

There is nothing architecture or platform specific about getting
the option enabled enough for you to see this:

drivers/net/hippi/Kconfig:40: syntax error
drivers/net/hippi/Kconfig:20: missing end statement for this entry
drivers/net/Kconfig:28: missing end statement for this entry
drivers/Kconfig:1: missing end statement for this entry
drivers/net/hippi/Kconfig:39: invalid statement
drivers/net/Kconfig:341: unexpected end statement
drivers/Kconfig:139: unexpected end statement
make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

I've fixed this up but if you can't be bothered to type "make" I
seriously can't be bothered to even look at your patch submissions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/