Re: [PATCH v2] drivers/net/usb/asix: resync from vendor's copy

[Ben Hutchings]

On Wed, 2011-11-09 at 12:31 -0500, Mark Lord wrote:
[...]
> +static int ax88172_link_reset(struct usbnet *dev)
> +{
> +       u16 lpa;
> +       u16 adv;
> +       u16 res;
> +       u8 mode;
> +
> +       mode = AX_MEDIUM_TX_ABORT_ALLOW | AX_MEDIUM_FLOW_CONTROL_EN;
> +       lpa = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_LPA);
> +       adv = ax8817x_mdio_read_le(dev->net, dev->mii.phy_id, MII_ADVERTISE);
> +       res = mii_nway_result(lpa|adv);
[...]

The argument to mii_nway_result() must be lpa & adv (the intersection of
supported modes, not the union!).

Ben

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/