Re: [PATCH 1/3] Introducing grant table V2 stucture

[Konrad Rzeszutek Wilk]

On Wed, Nov 09, 2011 at 11:11:22AM +0000, Paul Durrant wrote:
> Annie,
> 
>   Comments inline below...
> 
> > -----Original Message-----
> [snip]
> > -static struct grant_entry *shared;
> > +static union {
> > +	struct grant_entry_v1 *v1;
> > +	void *ring_addr;
> > +} shared;
> > +
> 
> 'ring_addr' seems like the wrong name here; how about 'raw'?

Or 'ring'. I asked Annie to change it from 'raw' to something else and the first
thing that came in my mind was 'ring_addr'. But this does not point to a ring, so
the 'ring' part is wrong.

Point here is to make it descriptive. 'raw' does not carry meaning of _what_
it is suppose to do. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/