Re: [PATCH v2 13/14] provide a version of cpuusage statistics insidecpu cgroup

From: Andrew Wagin
Date: Wed Nov 09 2011 - 09:18:36 EST


And look at cfs_rq->prev_sum_exec_runtime, probably it is not used too.
Usage of cfs_rq->sum_exec_runtime looks strange.

2011/11/9 Glauber Costa <glommer@xxxxxxxxxxxxx>:
> On 11/09/2011 09:51 AM, Andrew Wagin wrote:
>>
>> Hi Glauber,
>>
>>> diff --git a/kernel/sched.c b/kernel/sched.c
>>> index d93cfd4..b9296cd 100644
>>> --- a/kernel/sched.c
>>> +++ b/kernel/sched.c
>>> @@ -303,6 +303,7 @@ struct task_group {
>>>
>>>        struct cfs_bandwidth cfs_bandwidth;
>>>        struct kernel_cpustat __percpu *cpustat;
>>> +       u64 __percpu *cpuusage;
>>
>> I can't find where you use this variable, probably it may be removed.
>
> Indeed.
> This is a leftover from the previous attempt.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/