Re: [PATCH 2/2] USB-renesas: move to dma_transfer_direction

[Felipe Balbi]

Hi,

On Fri, Oct 14, 2011 at 10:09:10PM +0530, Vinod Koul wrote:
> fixup usage of dma direction by introducing dma_transfer_direction,
> this patch moves usb/renesas driver to use new enum
> 
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>

This looks ok too:

Acked-by: Felipe Balbi <balbi@xxxxxx>

Kuninori-san, please have a look and reply with your Acked-by if you
think it's ok.

> ---
> v2: split the usb patch into two patches
> 
>  drivers/usb/renesas_usbhs/fifo.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
> index a34430f..f5bc370 100644
> --- a/drivers/usb/renesas_usbhs/fifo.c
> +++ b/drivers/usb/renesas_usbhs/fifo.c
> @@ -591,10 +591,10 @@ static void usbhsf_dma_prepare_tasklet(unsigned long data)
>  	struct dma_async_tx_descriptor *desc;
>  	struct dma_chan *chan = usbhsf_dma_chan_get(fifo, pkt);
>  	struct device *dev = usbhs_priv_to_dev(priv);
> -	enum dma_data_direction dir;
> +	enum dma_transfer_direction dir;
>  	dma_cookie_t cookie;
>  
> -	dir = usbhs_pipe_is_dir_in(pipe) ? DMA_FROM_DEVICE : DMA_TO_DEVICE;
> +	dir = usbhs_pipe_is_dir_in(pipe) ? DEV_TO_MEM : MEM_TO_DEV;
>  
>  	sg_init_table(&sg, 1);
>  	sg_set_page(&sg, virt_to_page(pkt->dma),
> -- 
> 1.7.0.4
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature