Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp

From: Kevin Hilman
Date: Tue Nov 08 2011 - 12:41:52 EST


"Ramirez Luna, Omar" <omar.ramirez@xxxxxx> writes:

> Hi,
>
> On Fri, Nov 4, 2011 at 6:23 PM, Kevin Hilman <khilman@xxxxxx> wrote:
>>> +   .flags     Â= HWMOD_INIT_NO_RESET,
>>
>> Why is this needed?
> ...
>>> +   .flags     Â= HWMOD_INIT_NO_RESET,
>>
>> And this?
>
> I have this because the hwmod complains about a failure in hard reset,
> even though the reset deassert does complete after the clock is
> enabled. Later on, hwmod will warn again because of a wrong state when
> enabling, I believe because of the failure on _setup but didn't dig
> into it yet.

Please dig deeper into the reset failure.

We don't merge HWMOD_INIT_NO_RESET changes without a very good reason
(that is also well described in the changelog.)

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/