Re: [PATCH] hwmon: lm63: Add support for the NatSemi LM96163.

[Jean Delvare]

On Mon,  7 Nov 2011 11:20:58 +0100, Thierry Reding wrote:
> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/hwmon/lm63.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
> index 508cb29..94e373c 100644
> --- a/drivers/hwmon/lm63.c
> +++ b/drivers/hwmon/lm63.c
> @@ -483,7 +483,7 @@ static int lm63_detect(struct i2c_client *new_client,
>  		return -ENODEV;
>  	}
>  
> -	if (chip_id == 0x41 && address == 0x4c)
> +	if ((chip_id == 0x41 || chip_id == 0x49) && address == 0x4c)
>  		strlcpy(info->type, "lm63", I2C_NAME_SIZE);
>  	else if (chip_id == 0x51 && (address == 0x18 || address == 0x4e))
>  		strlcpy(info->type, "lm64", I2C_NAME_SIZE);

Oh, BTW... there's really no reason to reuse the "lm63" name when both
chips are not fully compatible. Please introduce a new name for the new
chip. It's fairly easy.

I've added detection support to sensors-detect:
http://dl.lm-sensors.org/lm-sensors/files/sensors-detect

I would appreciate if you could try it and report.

I would also appreciate if you could provide a dump of your chip's
registers (using the i2c-dev driver with i2cdump - part of the
i2c-tools package) for my collection.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/