Re: [PATCH 4/5] IIO:hwmon interface client driver.

From: Jonathan Cameron
Date: Mon Nov 07 2011 - 12:39:19 EST


>> +static int __devexit iio_hwmon_remove(struct platform_device *pdev)
>> +{
>> + struct iio_hwmon_state *st = platform_get_drvdata(pdev);
>> +
>> + hwmon_device_unregister(st->hwmon_dev);
>> + sysfs_remove_group(&pdev->dev.kobj, &st->attr_group);
>> + iio_hwmon_free_attrs(st);
>> + kfree(st->attrs);
>> + iio_channel_release_all(st->channels);
>> +
>
> Either I missed it before, or I am missing something now ... should
> there be kfree(st) here ?
>
> Thanks,
> Guenter

Gah! you are quite right. Good spot. I'll fix that one up and repost
this individual patch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/