Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness
From: Felipe Balbi
Date: Mon Nov 07 2011 - 05:05:13 EST
On Mon, Nov 07, 2011 at 11:01:27AM +0100, Voss, Nikolaus wrote:
> Hi,
>
> > IMHO, you should split this patch into three or more smaller patches.
> > You're doing lots of different things in one commit and it'll be a pain to
> > bisect should this cause any issues to anyone.
>
> I didn't split the patch because it is virtually a complete rewrite.
> Due to the severe limitations of the old driver, I think it should
> replace the old driver.
The final decision is up to Ben and/or Jean but I think we should
always have incremental patches, not sure if we should allow big patches
for the reasons above.
--
balbi
Attachment:
signature.asc
Description: Digital signature