Re: [PATCH] clocksource: Avoid selecting mult values that mightoverflow when adjusted

From: John Stultz
Date: Thu Nov 03 2011 - 09:10:45 EST


On Thu, 2011-11-03 at 13:05 +0100, Thomas Gleixner wrote:
> On Wed, 2 Nov 2011, John Stultz wrote:
> >
> > + WARN_ONCE(timekeeper.mult+adj >
> > + timekeeper.clock->mult + timekeeper.clock->maxadj,
> > + "Adjusting more then 11%%");
>
> Shouldn't we rather limit the update instead of just warn and overflow ?

Well, I'm hesitant to commit to that, just yet. So I figured I'd start
with the warning.

thanks
-john


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/