Re: [PATCH 4 of 5] virtio: avoid modulus operation

From: Rusty Russell
Date: Thu Nov 03 2011 - 06:42:29 EST


On Thu, 3 Nov 2011 09:51:15 +0200, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
> On Thu, Nov 3, 2011 at 9:42 AM, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> > Since we know vq->vring.num is a power of 2, modulus is lazy (it's asserted
> > in vring_new_virtqueue()).
> >
> > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> > ---
> > Âdrivers/virtio/virtio_ring.c | Â 10 ++++++----
> > Â1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> > --- a/arch/x86/lguest/boot.c
> > +++ b/arch/x86/lguest/boot.c
> > @@ -1420,7 +1420,7 @@ __init void lguest_init(void)
> > Â Â Â Âadd_preferred_console("hvc", 0, NULL);
> >
> > Â Â Â Â/* Register our very early console. */
> > - Â Â Â virtio_cons_early_init(early_put_chars);
> > +// Â Â virtio_cons_early_init(early_put_chars);
>
> What's this hunk here?

Ugly workaround for console until hvc_console breakage gets reverted.

Left in by mistake :)

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/