Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume

[Linus Torvalds]

Peter, Ingo, ping?

Quite frankly, I'm inclined to revert that patch just for being
horribly ugly and apparently broken regardless of the fact that it
also causes a regression.

*Notifiers* for doing something like this? smp_call_function? That's
just utter sh*t, guys.

If it is CPU state, then it should damn well be suspended and resumed
as part of CPU suspend and resume. No IPI cross-calls to ask other
CPU's to do random work, no crap like that.

Comments? Should I just revert the thing (silence is obviously "yes"
in cases like this where we are talking about regressions anyway)?

                   Linus

On Wed, Nov 2, 2011 at 6:49 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> Resume stopped working on my Acer Aspire 1830T post 3.1. The screen
> just stays black after wakeup.
>
> I bisected it down to
>
> commit 144060fee07e9c22e179d00819c83c86fbcbf82c
> Author: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Date:   Mon Aug 1 12:49:14 2011 +0200
>
>    perf: Add PM notifiers to fix CPU hotplug races
>
> Reverting this patch fixes the problem for me.
>
> -Andi
>
> --
> ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/