Re: [PATCH] arm/tegra: add support for tegra30 interrupts

From: Russell King - ARM Linux
Date: Wed Nov 02 2011 - 15:54:43 EST


On Wed, Nov 02, 2011 at 09:48:28PM +0200, Felipe Balbi wrote:
> Hi,
>
> you forgot to comment on the fact that gpio_desc shouldn't be held in an
> array. Any comments ?

I did not comment on that because that's someone elses problem.

> What I mean is that, just like irq_descs, we should be able to allocate
> them dynamically. Maybe, just like irq_descs, hold them in a radix tree
> and maybe even have a matching API "gpio_alloc_descs()".

Probably - I expect Grant would really like to see some patches along
those lines. As I say, someone elses problem.

But what is _our_ problem is what to do with all the ARCH_NR_GPIOs
that we have now, and stop them increasing. There is a trivial solution
to that which I outlined which can be used until GPIO gets something
along your idea - and which doesn't involve me having to argue with
those who think that the kernel should remain as small as possible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/