Re: [PATCH] arm/tegra: add support for tegra30 interrupts

From: Russell King - ARM Linux
Date: Wed Nov 02 2011 - 15:40:19 EST


On Wed, Nov 02, 2011 at 09:26:26PM +0200, Felipe Balbi wrote:
> would it be better to just change the default value in
> arm-generic/gpio.h to something very large ?
>
> I mean, ideally that wouldn't be gpio_desc wouldn't be an array anyway
> right ?

You'll excuse me if I take this slightly personally.

You really can't expect me to say that I'm fine with a 6K growth in
kernel size for something that not every platform needs if there's
been objections to maybe a 128 byte growth for including the V:P
patching code in the kernel by default.

Either we care about memory usage or we don't. If we don't, lets get
rid of offering ARM_PATCH_PHYS_VIRT in any configuration and always
build with the dynamic V:P stuff enabled for the trivial cases. I
mean:

config ARM_PATCH_PHYS_VIRT
- bool "Patch physical to virtual translations at runtime" if EMBEDDED
+ bool
default y
depends on !XIP_KERNEL && MMU
depends on !ARCH_REALVIEW || !SPARSEMEM
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/