Re: linux-next 20111025: warnings inrcu_idle_exit_common()/rcu_idle_enter_common()

From: Paul E. McKenney
Date: Wed Nov 02 2011 - 11:19:45 EST


On Wed, Nov 02, 2011 at 11:01:46PM +0800, Wu Fengguang wrote:
> On Wed, Nov 02, 2011 at 10:56:26PM +0800, Steven Rostedt wrote:
> > On Wed, 2011-11-02 at 07:44 -0700, Paul E. McKenney wrote:
> >
> > > rcu: Fix idle-task checks
> > >
> > > RCU has traditionally relied on idle_cpu() to determine whether a given
> > > CPU is running in the context of an idle task, but recent changes have
> > > invalidated this approach.
> >
> > Correct. idle_cpu() returns if the CPU is idle or not, not if the CPU is
> > running the idle thread. If the CPU wakes up on the idle thread and
> > there's tasks on the run queue, then idle_cpu() will return false, even
> > though the task running is the idle thread. But the CPU itself is not
> > technically idle.
> >
> > Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> With the patch I no longer see the RCU warnings. Below is the full dmesg.
>
> Tested-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>

... and your Tested-by.

Thank you all!!!

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/