Re: [PATCH] drm/i915: Fix object refcount leak on mmappable size limit error path.

[Eric Anholt]

On Mon, 31 Oct 2011 23:58:25 -0700, Keith Packard <keithp@xxxxxxxxxx> wrote:
Non-text part: multipart/signed
> On Mon, 31 Oct 2011 23:16:21 -0700, Eric Anholt <eric@xxxxxxxxxx> wrote:
> 
> > I've been seeing memory leaks on my system in the form of large
> > (300-400MB) GEM objects created by now-dead processes laying around
> > clogging up memory.  I usually notice when it gets to about 1.2GB of
> > them.  Hopefully this clears up the issue, but I just found this bug
> > by inspection.
> > 
> > Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxx
> 
> Reviewed-by: Keith Packard <keithp@xxxxxxxxxx
> 
> I wouldn't mind having someone audit the driver for more places where
> drm_gem_object_lookup might not be paired with drm_gem_object_unreference...

I went ahead and finished the read-through, and everything else looks
good.

Attachment: pgp00000.pgp
Description: PGP signature