Re: [RFC/PATCH 6/7] x86, mm: Prepare zone_sizes_init() for unification

From: Pekka Enberg
Date: Tue Nov 01 2011 - 02:32:55 EST


Hi David,

On Tue, Nov 1, 2011 at 12:56 AM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> I'd just fold patch 7 into this, it doesn't make much sense to have add
> CONFIG_HIGHMEM code for 64-bit, for example, just to make the next patch
> simpler.

Actually, I don't agree.

Whenever I've done unification patches, I've always made sure the
patch that does the actual unification is just code shuffling. That
improves bisectability and makes reviewing easier.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/