Re: [PATCH 2/3] mfd: Add s5m series irq support

From: Mark Brown
Date: Sun Oct 23 2011 - 04:42:36 EST


On Sun, Oct 23, 2011 at 05:07:26PM +0900, Sangbeom Kim wrote:
> This patch support irq for s5m series.
> Basically, S5M8767 and S5M8763 irq can be handled by this patch.

This all looks pretty good, though it looks somewhat familiar :)

Actually, one of the things I want to do in the 3.3 timeframe is to
factor out this code from my drivers into a regmap based irq_chip since
it seems a lot of people are "drawing inspiration" from it. This
shouldn't be any form of blocker for merging this driver though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/