Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug.

From: Rolf Eike Beer
Date: Sun Oct 23 2011 - 04:21:37 EST

Paul Schilling wrote:
> This fixes a DMA issue related to a CRC bug on
> the RDC pata peripherial found on the vortex86sx and vortex86dx.
>
> Signed-off-by: Paul Schilling <paul.s.schilling@xxxxxxxxx>
> ---
> drivers/ata/pata_it821x.c | 22 ++++++++++++++++++----
> drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++-----
> drivers/ide/it821x.c | 9 +++++++--
> include/linux/pci_ids.h | 2 ++
> 4 files changed, 51 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
> index c5532b9..5f8a54a 100644
> --- a/drivers/ata/pata_it821x.c
> +++ b/drivers/ata/pata_it821x.c
> @@ -897,7 +897,16 @@ static int it821x_init_one(struct pci_dev *pdev, const
> struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = {
> .flags = ATA_FLAG_SLAVE_POSS,
> .pio_mask = ATA_PIO4,
> - .mwdma_mask = ATA_MWDMA2,
> + .mwdma_mask = 0,
> + .udma_mask = 0,
> + /* No UDMA */
> + .port_ops = &it821x_rdc_port_ops
> + };
> + static const struct ata_port_info info_rdc_01 = {
> + .flags = ATA_FLAG_SLAVE_POSS,
> + .pio_mask = ATA_PIO4,
> + .mwdma_mask = 0,
> + .udma_mask = 0,
> /* No UDMA */
> .port_ops = &it821x_rdc_port_ops
> };

Why do you define this if it is never used?

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.