Re: [PATCH] Disable TCP_DEBUG and FASTRETRANS_DEBUG by default

[Dan McGee]

On Wed, Oct 19, 2011 at 12:16 PM, Flavio Leitner <fbl@xxxxxxxxxx> wrote:
> On Mon, 17 Oct 2011 17:52:38 -0400 (EDT)
> David Miller <davem@xxxxxxxxxxxxx> wrote:
>
>> From: Dan McGee <dpmcgee@xxxxxxxxx>
>> Date: Mon, 17 Oct 2011 15:25:24 -0500
>>
>> > If these are truly debug options, they should be turned off by default
>> > and can be tweaked if necessary. Fix one usage of the flag to use #if
>> > instead of #ifdef so defining to zero is acceptable.
>> >
>> > Signed-off-by: Dan McGee <dpmcgee@xxxxxxxxx>
>>
>> Illegal window shrinks are a serious issue, and the fact that everyone
>> will see those messages by default and sometimes report them has been
>> tremendously useful.
>>
>
> Agreed. I recently got bug report because of that message. ÂIt is useful
> and doesn't disturbe when network is fine, so please don't remove it.
Can we kill TCP_DEBUG completely then? This is the only place it is
used, and it clearly is mislabeled if this is a "serious" and "useful"
feature.

Can anyone weigh in on FASTRETRANS_DEBUG and setting that to 0 by default?

-Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/