Re: Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNELto unhide debug options"

From: Michal Marek
Date: Fri Oct 21 2011 - 08:37:46 EST


On 21.10.2011 11:22, Adrian Bunk wrote:
> On Fri, Oct 21, 2011 at 10:19:29AM +0200, Michal Marek wrote:
>> On 20.10.2011 23:41, Adrian Bunk wrote:
>>> Ingo, would you accept if I would go through the Kconfig files and
>>> monitor future changes to Kconfig files in the kernel (or if Michal does
>>> it, I don't insist that it has to be me if someone else wants to do it)?
>>
>> What kind of changes do you have in mind? Sorry, I haven't followed the
>> whole thread.
>
> Checking the correctness and making things more robust.
>
> An example:
>
> config KVM
> tristate "Kernel-based Virtual Machine (KVM) support"
> ...
> # for TASKSTATS/TASK_DELAY_ACCT:
> depends on NET
> ...
> select TASKSTATS
> select TASK_DELAY_ACCT
>
> That breaks if anyone touches the dependencies of TASKSTATS
> or TASK_DELAY_ACCT.
>
> It should be solved better, my first thought would be introducing
> something like a TASK_DELAY_ACCT_AVAILABLE variable.

Right, but that's a deficiency of the kconfig solver. Catalin Marinas
has patched it to at least print a warning if a dependency of a
select-ed symbol is not set. Ideally, we should get a better solver.

Michal

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/