Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

From: Mark Brown
Date: Fri Oct 21 2011 - 04:58:43 EST


On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.

This patch doesn't apply against current code.

> +/*
> + * DAPM Controls
> + *
> + * Current DAPM implementation covers almost all codec components e.g. IOs,
> + * mixers, PGAs,ADC and DAC.

This explanation would better placed next to the code in the probe -
it's that code which looks out of place in a Linux driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/