Re: [PATCH 5/7] writeback: requeue_io_wait() on pages_skipped inode

[Jan Kara]

On Thu 20-10-11 23:22:45, Wu Fengguang wrote:
> Use requeue_io_wait() if some pages were skipped due to locked buffers.
> 
> Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> Cc: Michael Rubin <mrubin@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Fengguang Wu <wfg@xxxxxxxxxxxxxxxx>
> Signed-off-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
  Two signed-off-by?

Otherwise
  Acked-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/fs-writeback.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next.orig/fs/fs-writeback.c	2011-10-20 22:42:24.000000000 +0800
> +++ linux-next/fs/fs-writeback.c	2011-10-20 22:42:25.000000000 +0800
> @@ -618,11 +618,11 @@ static long writeback_sb_inodes(struct s
>  		if (wbc.pages_skipped) {
>  			/*
>  			 * writeback is not making progress due to locked
>  			 * buffers.  Skip this inode for now.
>  			 */
> -			redirty_tail(inode, wb);
> +			requeue_io_wait(inode, wb);
>  		}
>  		spin_unlock(&inode->i_lock);
>  		spin_unlock(&wb->list_lock);
>  		iput(inode);
>  		cond_resched();
> 
> 
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/