Re: [PATCH 2/9] x86, RAS: Start reorganizing RAS features support

[Borislav Petkov]

On Wed, Oct 19, 2011 at 03:14:08PM -0400, Mauro Carvalho Chehab wrote:
> > I don't consider MCE decoding and injection drivers but rather MCA
> > functionality extensions or something, so those should go to arch/x86/
> > IMHO.
> 
> Agreed. MCE decoders and MCE error injection fit better together with
> MCA bits. I think they could just be moved to be into the same directory where 
> the MCE driver is located.

I think you mean arch/x86/kernel/cpu/mcheck/. Well, that _is_ possible,
since they're MCA extensions.

> > And the DRAM error decoding things, aka EDAC, should stay where they
> > are, although I cannot call them real drivers, either. We can't move
> > them yet anyway because they use the whole EDAC infrastructure.
> 
> True.
> 
> From someone that wants to select the RAS features however, it makes sense 
> to put everything together at the same menu when selecting the RAS options.
> 
> There are some tricks that could be used, like, for example, having something
> like:
> 
> menuconfig RAS_FEATURES
> 	bool "Enable RAS features"
> 
> if RAS_REATURES
> 
> config RAS_MCE
> 	bool "turn on Memory Channel Architecture Error logic for AMD CPU's"
> 	depends on X86
> 	select X86_MCE_AMD
> 
> config RAS_MCE
> 	bool "turn on Memory Channel Architecture Error logic for Intel CPU's"
> 	depends on X86
> 	select X86_MCE_INTEL
> 
> source "drivers/edac"
> 
> endif
> 
> at a /drivers/ras Kconfig (or at /ras)
> 
> This would allow putting everything together at the same Kconfig menu.

Ok, we could do that too, it has merits.

Let's discuss all this at KS.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/