Re: [PATCH] tools/perf: Increase symbol KSYM_NAME_LEN size

[Ricardo Ribalda Delgado]

That is 4gb size :S..... I have tried making a dummy program

int tttttt......ttttt (int a, int b){
return a+b;
}

int main(int arg, char *[]argv){
    return tttt....tttt(1,2);
}

and it has worked at least until t^16384 both in gcc and in gdb, and I
guess it would have continue working until much more.

Right now, I think we can increase it until 512, to be on the safe
side, and keep it simple. What do you think?

  best regards

On Thu, Oct 20, 2011 at 10:14, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
> On Thu, Oct 20, 2011 at 10:54:40AM +0300, Pekka Enberg wrote:
> ...
>>
>> Is there some specified maximum length for symbols (e.g. in ELF spec)?
>> I'm OK with the patch but I'd prefer we didn't bump up the number
>> blindly there's something "official" number we can use.
>>
>>                         Pekka
>
> Elf restricts offsets in string table by 4 bytes, so probably the option
> is to have complete .strtab being read somewhere and use indices when needed.
> (note I didn't check where perf tool need those names).
>
>        Cyrill
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/