Re: [PATCH] tools/perf: Increase symbol KSYM_NAME_LEN size

[Pekka Enberg]

On Thu, Oct 20, 2011 at 10:43 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@xxxxxxxxx> wrote:
> Fglrx propietary driver has symbol names over 128 chars (:S). This
> breaks the function kallsyms__parse.
>
> This fix increases the size of KSYM_NAME_LEN, so kallsyms__parse can
> work on such kernels.
>
> The only counterparty, is that such function requires 128 more bytes to
> work.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> ---
>  tools/perf/util/symbol.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 40eeaf0..d4f8750 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -24,7 +24,7 @@
>  #include <sys/utsname.h>
>
>  #ifndef KSYM_NAME_LEN
> -#define KSYM_NAME_LEN 128
> +#define KSYM_NAME_LEN 256
>  #endif
>
>  #ifndef NT_GNU_BUILD_ID
> --
> 1.7.7

Is there some specified maximum length for symbols (e.g. in ELF spec)?
I'm OK with the patch but I'd prefer we didn't bump up the number
blindly there's something "official" number we can use.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/