Re: [Patch] Idle balancer: cache align nohz structure to improve idle load balancing scalability

From: Andi Kleen
Date: Thu Oct 20 2011 - 00:24:54 EST


Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx> writes:
> */
> static struct {
> - atomic_t load_balancer;
> - atomic_t first_pick_cpu;
> - atomic_t second_pick_cpu;
> - cpumask_var_t idle_cpus_mask;
> + atomic_t load_balancer ____cacheline_aligned;
> + atomic_t first_pick_cpu ____cacheline_aligned;
> + atomic_t second_pick_cpu ____cacheline_aligned;
> + cpumask_var_t idle_cpus_mask ____cacheline_aligned;

On large configs idle_cpu_masks may be allocated. May need
more changes to tell the allocator to cache align/pad too?

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/