Re: [PATCH 2/2] gpio-ml-ioh: Use NUMA_NO_NODE not GFP_KERNEL

[Grant Likely]

On Wed, Oct 19, 2011 at 10:37:40AM +0900, Tomoya MORINAGA wrote:
> Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
> 
>           irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
>                                      GFP_KERNEL);
> 
> This is not true.
> So, this patch uses NUMA_NO_NODE not GFP_KERNEL.

Applied both, thanks.

g.

> 
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reported-by: David Rientjes <rientjes@xxxxxxxxxx>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpio/gpio-ml-ioh.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 88d65be..1b59003 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -429,7 +429,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
>  	chip = chip_save;
>  	for (j = 0; j < 8; j++, chip++) {
>  		irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> -					   GFP_KERNEL);
> +					   NUMA_NO_NODE);
>  		if (irq_base < 0) {
>  			dev_warn(&pdev->dev,
>  				"ml_ioh_gpio: Failed to get IRQ base num\n");
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/