Re: [PATCH 8/9] x86, RAS: Add attributes needed for HW injection

[Borislav Petkov]

On Wed, Oct 19, 2011 at 05:03:43PM -0400, David Rientjes wrote:
> > +static int inj_extcpu_set(void *data, u64 val)
> > +{
> > +	struct mce *m = (struct mce *)data;
> > +
> > +	if (val >= num_online_cpus()) {
> 
> That wouldn't catch an offline cpuid, you probably want cpu_online(val)?

Good catch, thanks.

So I'm looking at <arch/x86/kernel/cpuid.c> which is how the validity of
a cpu value should be tested properly, IMHO:

static int cpuid_open(struct inode *inode, struct file *file)
{
	...

	if (cpu >= nr_cpu_ids || !cpu_online(cpu))
		return -ENXIO;	/* No such CPU */
	...

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/