Re: [PATCH 3/3] sound/soc/au1x: keep pointer to resource so it can be freed

From: Girdwood, Liam
Date: Wed Oct 19 2011 - 12:47:29 EST


On 19 October 2011 15:50, Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx> wrote:
> On Tue, Oct 18, 2011 at 5:45 AM, Julia Lawall <julia@xxxxxxx> wrote:
>> From: Julia Lawall <julia@xxxxxxx>
>>
>> Add a new variable for storing resources accessed subsequent to the one
>> accessed using request_mem_region, so the one accessed using
>> request_mem_region can be released if needed.
>>
>> This code is also missing some calls to iounmap.
>
> How about something much simpler, like this:
>
> From 940e38b3f0beff6fcd8f62f627dce622e9ca0e54 Mon Sep 17 00:00:00 2001
> From: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx>
> Date: Wed, 19 Oct 2011 16:45:12 +0200
> Subject: [PATCH] ASoC: au1x: fix error paths in ac97c/i2cs probe callbacks.
>
> add iounmap() and release the correct mem resource.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx>

Acked-by: Liam Girdwood <lrg@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/