Re: [PATCH 1/2] ASoC: sgtl5000: Fix define for SGTL5000_BIAS_R_MASK

[Girdwood, Liam]

On 19 October 2011 03:54, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> According to the datasheet:
> CHIP_MIC_CTRL 0x002A
>
> BITS[9:8] BIAS_RESISTOR
> Â Â Â Â0x0 = Powerd off
> Â Â Â Â0x1 = 2.0 kohm
> Â Â Â Â0x2 = 4.0 kohm
> Â Â Â Â0x3 = 8.0 kohm
>
> Thus SGTL5000_BIAS_R_MASK should be defined as 0x0300 instead of 0x0200.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> Âsound/soc/codecs/sgtl5000.h | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
> index eec3ab3..8a9f435 100644
> --- a/sound/soc/codecs/sgtl5000.h
> +++ b/sound/soc/codecs/sgtl5000.h
> @@ -280,7 +280,7 @@
> Â/*
> Â* SGTL5000_CHIP_MIC_CTRL
> Â*/
> -#define SGTL5000_BIAS_R_MASK Â Â Â Â Â Â Â Â Â 0x0200
> +#define SGTL5000_BIAS_R_MASK Â Â Â Â Â Â Â Â Â 0x0300
> Â#define SGTL5000_BIAS_R_SHIFT Â Â Â Â Â Â Â Â Â8
> Â#define SGTL5000_BIAS_R_WIDTH Â Â Â Â Â Â Â Â Â2
> Â#define SGTL5000_BIAS_R_off          Â0x0
> --
> 1.7.5.4
>
>
>
>

Both

Acked-by: Liam Girdwood <lrg@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/