Re: patch] cpusets, cgroups: disallow attaching kthreadd

From: Paul Menage
Date: Wed Oct 19 2011 - 00:56:39 EST


On Tue, Oct 18, 2011 at 9:00 PM, Mike Galbraith <efault@xxxxxx> wrote:
>
> Oh my, I can't win.
>
> Either of the two patchlets will do the trick, so maintainer's choice.
>

I agree with your original idea - if it's just some cgroup subsystems
that are unsafe to have kthreadd in, then they can make that choice.

Otherwise you restrict things unnecessarily. E.g. a systemd-alike
might have a tracking hierarchy (without any subsystems attached,
potentially) and want to keep the top-level empty and have all kernel
threads their own cgroup. There's absolutely no problem with that.

I can see the argument that the number of use-cases for this is fairly
small, but in line with the principle of keeping the ABI as stable as
possible in the absence of bugs that force a change, having the
restriction in the necessary subsystems seems cleaner.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/